Replace fputc with ungetc to fix UB #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also add a test in the commit prior to the fix to ensure it works? |
|
That's a good plan, I'll amend one of the EncryptedStream tests and ensure that it can still decrypt properly after this change. Given that the original bug with the UB seems system-dependent, I'm not sure I can guarantee that the test would fail before this fix, but I'll see if I can get it going in WSL. |
zrax
approved these changes
Oct 1, 2024
|
Added a test, but it seems to pass both with and without the |
zrax
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185.