Include Winsock header only where it's actually used #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnNetCommon is also the only library that actually links with Winsock, so including the header elsewhere doesn't make much sense.
Although AF_INET is always 2 on every relevant system, it's better not to assume this. Here, we use AF_INET only as a marker value in a serialization format and never pass it to any system functions, so it's more important that the value is consistent between systems than that it matches the system constant.
zrax
reviewed
Aug 18, 2023
Only has kInet (AF_INET, IPv4) for now. This will be relevant if IPv6 support is ever added here - unlike AF_INET, which is 2 on all relevant OSes, AF_INET6 has a different value on Windows, macOS, and Linux.
zrax
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnNetCommon is also the only library that actually links with Winsock, so including the header elsewhere doesn't make much sense.