Port plVaultClientApi to standard C++ containers #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The owner and seen info was never used here. It's not even clear what they would refer to, because every node appears exactly once in s_nodes, regardless of how many refs it has.
As with s_nodes, the owner and seen info was never used here. The fields were never filled in either, even though here it's clear which values they should have.
Hoikas
reviewed
Aug 17, 2023
|
I wonder... considering that all |
|
I think that would be ideal (in another PR), but we'd want to make sure that |
Hoikas
reviewed
Aug 17, 2023
dgelessus
force-pushed
the
plvault_std_containers
branch
from
1fb140d
to
b760a54
Compare
Hoikas
reviewed
Sep 5, 2023
Hoikas
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I go, touching more important and complex code - what could go wrong?
More seriously, this makes the vault logic a bit more readable and less complex, because it eliminates some manual memory management and wrapper structs. Some of the code is still quite verbose though, because of how the C++ map API is designed.
This eliminates the last use of the weird custom intrusive hash table pnUtHash (aka
HASHTABLEDECL/HASHLINK).