Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid runtime indirection when initializing plCreatable class indices #1449

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Avoid runtime indirection when initializing plCreatable class indices #1449

merged 3 commits into from
Aug 7, 2023

Commits on Aug 6, 2023

  1. Initialize plCreatable class index fields with constants 

    The plCreator implementations don't have any subclasses themselves, so
the value of ClassIndex() is a known compile-time constant and the
runtime indirection through the virtual method isn't needed.
    @dgelessus
    dgelessus committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    bd9aa5b View commit details
    Browse the repository at this point in the history

  2. Replace unnecessary dynamic ClassIndex call in plFactory::FindClassIndex

    @dgelessus
    dgelessus committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    71aebc1 View commit details
    Browse the repository at this point in the history

  3. Require semicolons after all plCreator.h macros

    @dgelessus
    dgelessus committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    020cb20 View commit details
    Browse the repository at this point in the history