-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign sequential object IDs at Max export time #1425
Conversation
So, it occurs to me that this has the same problem that libhsplasma had previously. What's happening here is that a PRP's ObjIDs are being sorted, then the PRP is written. Then, the next PRP's ObjIDs are sorted and the PRP is written. So, any cross-page references between PRPs may be shattered due to wrong ObjIDs being written if a reference is written out to another PRP before the other PRP is sorted. Therefore, the PrepForWrite function needs to be called on all RegistryPageNodes before any PRP is written. |
Let's go ahead and preemptively fix that problem so we don't have any land mines waiting on us. Cyan tended to be pretty good about limiting themselves one or two PRPs per max file, but we need to be more resilient due to not being on the other side of the hallway from our users 😉 |
Co-Authored-By: Adam Johnson <AdamJohnso@gmail.com>
eace4af
to
92ed289
Compare
I exported the Nexus max files with this, and it appears that all the Object IDs are sequential. |
Co-Authored-By: Adam Johnson <AdamJohnso@gmail.com>
92ed289
to
3acfabb
Compare
No description provided.