fix(metric-engine): set ttl also on opening metadata regions #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or TTL option handling in MetricEngineInner
…into a shared function • Extract metadata region options into region_options_for_metadata_region function • Replace inline options map with a call to the new shared function in both create.rs and open.rs files
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
killme2008
reviewed
Nov 26, 2024
evenyag
approved these changes
Nov 26, 2024
Refactor metadata region options to accept original options and remove APPEND_MODE_KEY
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
==========================================
- Coverage 83.93% 83.68% -0.26%
==========================================
Files 1155 1155
Lines 216134 216138 +4
==========================================
- Hits 181418 180875 -543
- Misses 34716 35263 +547 |
evenyag
pushed a commit
that referenced
this pull request
Nov 26, 2024
* fix/metric-metadata-region-options: Remove APPEND_MODE_KEY and refactor TTL option handling in MetricEngineInner * fix/metric-metadata-region-options: Refactor metadata region options into a shared function • Extract metadata region options into region_options_for_metadata_region function • Replace inline options map with a call to the new shared function in both create.rs and open.rs files * fix: exclude typos * fix/metric-metadata-region-options: Refactor metadata region options to accept original options and remove APPEND_MODE_KEY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5044
What's changed and what's your intention?
The region options for metadata region in metric engines should stay independent from database options, no matter during opening or creating regions.
Checklist