-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(grafana): update cluster dashboard #4980
refactor(grafana): update cluster dashboard #4980
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Big changes for the GreptimeDB cluster Grafana dashboard. Here is the screenshot:
Refactor the variables(use
greptime_app_version
for pods self-discovery):metrics
: The Prometheus data source;information_schema
: The SQL instance which to expose metadata of the cluster;roles
: Select different roles;pods
: Select different pods;Base on the above variables, the new dashboard defines the new variables to describe roles:
datanode
/frontend
/metasrv
/flownode
.Add the
Overview
andResources
:Overview
is the summary of the whole cluster;Resources
is the total CPU and memory for the different roles of the cluster(TODO: I haven't added the CPU metric yet; maybe can useprocess_cpu_seconds_total
);Split QPS and P99 into two different graphs to make it easy to read, for example:
Checklist