-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function to aggregate path into a geojson path #4798
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
567dc95
to
da46971
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
- Coverage 84.45% 84.16% -0.30%
==========================================
Files 1120 1122 +2
Lines 204139 204267 +128
==========================================
- Hits 172414 171924 -490
- Misses 31725 32343 +618 |
The return type is not geojson at all. It's just compatible with geojson's coordinates part and superset's deckgl path plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
In greptimedb, we store waypoints of a path row by row. However, when using with data process or visualization software, it treats a trajectory as a single value, either in geojson or other formats.
This patch introduces a new uadf
geojson_encode_path
that takes rows of latitude, longitude and timestamp to output a path that compatible with deckgl's path input.It also refactors our macro for aggregation function to remove
use
from macro to avoid multiple use error when using the macro.sqlness tests included.
Checklist