-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json format output for http interface #4797
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The branch includes commits from my last PR. Not sure what the cause is. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4797 +/- ##
==========================================
- Coverage 84.45% 84.22% -0.24%
==========================================
Files 1120 1121 +1
Lines 204139 204520 +381
==========================================
- Hits 172414 172251 -163
- Misses 31725 32269 +544 |
I think it's because you created this branch from your last feature branch. If your previous branch has been merged, you can rebase to main to fix that |
d54cd7f
to
34c873c
Compare
I thought so too. thx |
Almost LGTM. It would be nice if we can add a test case in |
Added a test case. Let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW: it would be nice to add more tests, such as affected_rows
cases and select count(1)
cases where the column name is not the schema column name.
Possible future works: add total_rows
in metadata for queries.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Closes #4764.
What's changed and what's your intention?
As explained in #4764, it's better if the http service return a json format that is already supported by other products.
Checklist