-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add tests for KvBackend trait implement #3700
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 85.57% 85.23% -0.34%
==========================================
Files 962 963 +1
Lines 160274 160605 +331
==========================================
- Hits 137155 136898 -257
- Misses 23119 23707 +588 |
@realtaobo Thank you. There are some TOML format issues and cargo clippy warnings, could you fix them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@realtaobo Please update the PR description for what behavior tests your added.
Reverse engineering and guess from the code is unfriendly for reviewers.
Got it. Finished. |
Signed-off-by: tison <wander4096@gmail.com>
cc @MichaelScofield PTAL. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #2618
What's changed and what's your intention?
For now,
KvBackend
trait has some implements, such asChrootKvBackend
,MemoryKvBackend
, etc. But onlyRaftEngineBackend
,MemoryKvBackend
andEtcdStore
will directly access the data. PR #2615 has been added some tests forRaftEngineBackend
andMemoryKvBackend
, this PR forEtcdStore
to ensure all implements have the same behaviors.Other
KvBackend
trait implements basedRaftEngineBackend
,MemoryKvBackend
andEtcdStore
implement,I think it's unnecessary.Tests mainly for range、put、batch_put、batch_get、compare_and_put、delete_range、batch_delete.
Checklist