fix: physical table statistics info

GreptimeTeam · Nov 12, 2024 · 02a8b2f · 02a8b2f
1 parent 84aa5b7
commit 02a8b2f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/catalog/src/system_schema/information_schema/tables.rs b/src/catalog/src/system_schema/information_schema/tables.rs
@@ -34,6 +34,7 @@ use datatypes::vectors::{
 };
 use futures::TryStreamExt;
 use snafu::{OptionExt, ResultExt};
+use store_api::metric_engine_consts::PHYSICAL_TABLE_METADATA_KEY;
 use store_api::storage::{RegionId, ScanRequest, TableId};
 use table::metadata::{TableInfo, TableType};
 
@@ -259,7 +260,13 @@ impl InformationSchemaTablesBuilder {
                 let table_info = table.table_info();
 
                 // TODO(dennis): make it working for metric engine
-                let table_region_stats = if table_info.meta.engine == MITO_ENGINE {
+                let table_region_stats = if table_info.meta.engine == MITO_ENGINE
+                    || table_info
+                        .meta
+                        .options
+                        .extra_options
+                        .contains_key(PHYSICAL_TABLE_METADATA_KEY)
+                {
                     let region_ids = table_info
                         .meta
                         .region_numbers

diff --git a/src/common/meta/src/datanode.rs b/src/common/meta/src/datanode.rs
@@ -77,7 +77,7 @@ pub struct RegionStat {
     pub rcus: i64,
     /// The write capacity units during this period
     pub wcus: i64,
-    /// Approximate bytes of this region
+    /// Approximate disk bytes of this region, including sst, index, manifest and wal
     pub approximate_bytes: u64,
     /// The engine name.
     pub engine: String,