feat: support apt colon arch syntax #38
Conversation
debian package files seem to make use of this shorthand in packages that depend on python: Architecture: all Depends: python3:any This PR adds support for parsing this correctly, fixing the error whereby python3:any would be assumed to be the name of the whole package
|
sorry for the diff in bullseye.lock. I think my ide reformatted it. I'll fix that up. |
|
Actually I'm not sure what caused that, it seems to be a whitespace-only change that is reproducible when I run |
| # Depends: python3:any | ||
| # is equivalent to | ||
| # Depends: python3 [any] | ||
| colon_i = raw.find(":") |
There was a problem hiding this comment.
Can you add some tests for this here: https://github.com/GoogleContainerTools/rules_distroless/blob/main/apt/tests/package_resolution_test.bzl
|
Thanks for the pointer to that directory -- I added a simple case for |
|
Could you solve the conflicts? |
|
Happily! Conflicts resolved |
|
PR is bumping into #36, can you remove the new package? |
|
i believe you need to regenerate the lockfile again. |
|
Hmm interesting, I ran that after the merge conflict and it generated a smaller file but with some additional dependencies, and when I just ran it again, there was no change. Is it possible this fix has unmasked dependencies that were missing? They seem to be gcc related, which I have seen use the |
|
yeah that's probably it. thank you! |
debian package files seem to make use of this shorthand in packages that depend on python:
Architecture: all
Depends: python3:any
This PR adds support for parsing this correctly, fixing the error whereby python3:any would be assumed to be the name of the whole package