refactor: bring deb_index on par with bzlmod api #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
remove_workspace
branch
2 times, most recently
from
c5bb79a
to
2fedfd9
Compare
thesayyn
force-pushed
the
remove_workspace
branch
from
2fedfd9
to
2e778bb
Compare
thesayyn
force-pushed
the
remove_workspace
branch
from
2e778bb
to
9f6a7d9
Compare
thesayyn
force-pushed
the
remove_workspace
branch
from
819be6e
to
6d0efdf
Compare
jbedard
approved these changes
Nov 14, 2024
| @@ -4,26 +4,41 @@ | |||
| "https://bcr.bazel.build/bazel_registry.json": "8a28e4aff06ee60aed2a8c281907fb8bcbf3b753c91fb5a5c57da3215d5b3497", | |||
| "https://bcr.bazel.build/modules/abseil-cpp/20210324.2/MODULE.bazel": "7cd0312e064fde87c8d1cd79ba06c876bd23630c83466e9500321be55c96ace2", | |||
| "https://bcr.bazel.build/modules/abseil-cpp/20211102.0/MODULE.bazel": "70390338f7a5106231d20620712f7cccb659cd0e9d073d1991c038eb9fc57589", | |||
| "https://bcr.bazel.build/modules/abseil-cpp/20211102.0/source.json": "7e3a9adf473e9af076ae485ed649d5641ad50ec5c11718103f34de03170d94ad", | |||
There was a problem hiding this comment.
I don't think this file should be checked in? Looks like it already was though 🤷♂️
There was a problem hiding this comment.
Yeah, it's fine to check this in imho.
| @@ -15,8 +15,8 @@ bzl_library( | |||
| ) | |||
|
|
|||
| bzl_library( | |||
| name = "index", | |||
| srcs = ["index.bzl"], | |||
| name = "apt", | |||
|
|
||
| http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
for some reason use_repo_rule rejects dev_dependency attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt.installto make bzlmod and nonbzlmod api similar.