Added passing of data between staged scenes #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Looking good, just some nitpicking issues.
My only worry is breakage on XRToolsSceneBase.scene_loaded. If someone has implemented their own code in an extended scene, GDScript will not call that because it hasn't got the user_data parameter now defined in it.
We should probably add a minor-breakage tag in the VERSIONS.md file.
We probably should think of how we want to maintain small footnotes about this in our releases (and since I copy those from VERSIONS.md maybe there as well) to instruct users to make minor changes like this.
Malcolmnixon
force-pushed
the
staging-spawn-data
branch
from
affdd54
to
caf15bf
Compare
Added passing of user_data between scenes. Added default handling of string/vector3/transform3d user_data as spawn-point. Added extended documentation about staging signals and methods. Modified demo teleporter to support optional spawn-point data. Add minor-breakage comment to VERSIONS.md. Disable warnings for unused parameters on interface functions intended for overriding. Added support for user_data objects with "get_spawn_position" method.
Malcolmnixon
force-pushed
the
staging-spawn-data
branch
from
caf15bf
to
a8622d0
Compare
|
I added a bolded minor-breakage at the start of the VERSIONS.md line to highlight the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows optional data to be passed between scenes. The default handler of this data will use it to try and override the spawn-point of the player. The specifics of this pull request are: