-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitals Boxing Ring collision hands demo #495
base: master
Are you sure you want to change the base?
Conversation
d1b9718
to
b990bc9
Compare
b990bc9
to
991d0a1
Compare
991d0a1
to
08a60a4
Compare
bump from my pov, i tried recreating the pickable collision logic with the New collision hand and it falls and overcomplicates, we would need to account for twohanded and for evry other extra handposition, this would mean to either move the collision copy evry time or to Delete and recreate it, this Producess unwanted physics reactions Regarding weight, i was unable to add drag to the forcebody3d node, probably just my lack of skill here. Amyways, this pr is soon havin its 1st birthday, so cake or no is the question |
I'll rebase this again so that it is mergeable but leave out anything that relies on features that we haven't implemented in XR Tools 1. In XR Tools 2 I've already implemented proper collisions on fingers and transfering collisions from picked up object, so we'll continue on the implementation there once public. |
Just to clarify, v1 wont get pickable collision? and were u by any Chance succesfull adding the weight feel? |
Co-Authored-By: Miodrag Sejic <56046022+DigitalN8m4r3@users.noreply.github.com>
08a60a4
to
dda0cf8
Compare
I need to do a bit more testing but this is now rebased on the current collision hands logic so most should be working. |
Definitely have a few more things to fix. Can't walk up the stairs, obviously weights don't work (yet) and hitting the punching bag needs to be improved a little |
Will test it soon, weights? that would complement v1.. |
First in a couple of PRs that will add Digitals boxing ring demo (#478) into XR Tools while solving a number of rebase issues and adjust the demo to work with the logic we're polishing up.
I'm not finished with this yet as time is short but some early feedback would be appreciated.
Things that will be fixed/dealt with in follow up PRs: