Fix texture copy for Forward+ renderer #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the texture copy from XRInterfaceExtension's the _end_frame to _post_draw_viewport. This seems to fix the fix the barrier issue with T5's rendering. Output seems smooth now with no glitches.
BastiaanOlij
reviewed
Oct 9, 2023
| @@ -13,6 +13,7 @@ config_version=5 | |||
| config/name="TiltFiveGodot4" | |||
| run/main_scene="res://main.tscn" | |||
| config/features=PackedStringArray("4.1") | |||
| run/max_fps=60 | |||
There was a problem hiding this comment.
Did you mean to add this in?
There was a problem hiding this comment.
Not really but it shouldn't do any harm. I've been told the T5 won't run over 60fps.
BastiaanOlij
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the texture copy from XRInterfaceExtension's the _end_frame to _post_draw_viewport. This seems to fix the fix the barrier issue with T5's rendering. Output seems smooth now with no glitches.