Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for Godot 4.1 #441

Open
wants to merge 6 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

Alexejhero
Copy link

@Alexejhero Alexejhero commented Nov 18, 2024

Changes made:

  • Removed typed for...in variables because Godot 4.1 doesn't support them
  • Downgraded some .tres to format version 3, because format version 4 isn't supported in Godot 4.1
  • Used custom function instead of type_string, which does not exist in Godot 4.1
I made the changes in the web editor because I didn't want to bother cloning the repo, you can squash the commits :)

I did a proper test in Godot 4.1 and encountered no issues.

Yes, I downloaded the addons folder from github after changing it in web

I did not test in later versions of Godot, but I don't think there's anything here that could break.

@Alexejhero Alexejhero marked this pull request as draft November 18, 2024 16:28
@Alexejhero Alexejhero marked this pull request as ready for review November 18, 2024 16:53
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Nov 18, 2024
@KANAjetzt KANAjetzt added the 4.x label Nov 18, 2024
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in 4.3 and works! Thank you!

Comment on lines +130 to 131
for mod in mod_data.values():
if not mod.is_loadable:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep the type in the loop, we can do something fun like this:

Suggested change
for mod in mod_data.values():
if not mod.is_loadable:
for _mod in mod_data.values():
var mod: ModData = _mod
if not mod.is_loadable:

@KANAjetzt KANAjetzt changed the title Fix support for Godot 4.1 fix: support for Godot 4.1 Nov 18, 2024
@Alexejhero

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants