Improve MCPL ticking data and behaviour #865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync-handling # Conflicts: # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/clientbound/ClientboundRecipePacket.java
Notable info: ServerboundSelectBundleItemPacket is not ticked, it's instant ClientboundSetHeldSlotPacket is already ticked as it is just renamed ClientboundSetCarriedItemPacket
|
This PR is now updated for 1.21.3 |
protocol/src/main/java/org/geysermc/mcprotocollib/network/packet/Packet.java
Show resolved
Hide resolved
|
PR is now fully ready for review & merge |
onebeastchris
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to get EXACT 1:1 ticking behavior with vanilla. Developers will now be able to provide their own async packet tick executors rather than mcpl forcing it to be an eventloop.
Some packets have been also put into proper packages. Such as the cookie packets in the cookies package and ping packets in the ping package, just like vanilla.
Some packets have exceptions and are only after specific code/in specific state ticked async. Those have been marked with a // GAME THREAD DETAIL comment.
This PR is ready for merging, thanks.