migrate to newrelic 2.1.0 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekostya
force-pushed
the
newrelic_2.1.0
branch
from
7af659d
to
42a1839
Compare
AlexeySoshin
approved these changes
Dec 9, 2018
izaurio
reviewed
Dec 26, 2018
| @@ -45,43 +45,43 @@ func WrapHandler(app newrelic.Application, name string, handler http.Handler) ht | |||
| } | |||
|
|
|||
| // Segment returns the New Relic Segment object from context. | |||
| func Segment(ctx context.Context) newrelic.Segment { | |||
| if sgm, ok := ctx.Value(segment).(newrelic.Segment); ok { | |||
| func Segment(ctx context.Context) *newrelic.Segment { | |||
There was a problem hiding this comment.
Why did you change the signature of the function?
There was a problem hiding this comment.
because newrelic v2 changed this signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to go.mod and newrelic v2.1.0
we have problem with travis and go mod
go mod required to place module not in gopath but travis do it.
i include GO111MODULE=on to skip this checker but we should fix that in travis