Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSLUX-670: Fix drag and drop for firefox #96

Merged
merged 4 commits into from
Apr 25, 2024
Merged

GSLUX-670: Fix drag and drop for firefox #96

merged 4 commits into from
Apr 25, 2024

Conversation

AlitaBernachot
Copy link
Contributor

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-XXX

Description

  • Fixed drag and drop on firefox (force Sortablejs to enable dragndrop fallback -no html5 dnd-)
  • Fixed ghost dragging style for firefox
  • Added --force option to force vite to clean node_modules cache on npm start (dev mode only)

@github-actions GitHub Actions
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-670-fix-dnd-firefox/

mki-c2c
mki-c2c requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration in v3 does not seem to work correctly:
while dragging, all layers become invisible and items can only be dragged upwards, not downwards.

src/components/layer-manager/layer-item/layer-item.spec.ts Outdated Show resolved Hide resolved
mki-c2c
mki-c2c approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please rename the typos ?

@AlitaBernachot
Copy link
Contributor Author

could you please rename the typos ?

yes, done 🙂

@AlitaBernachot AlitaBernachot merged commit f71c8f0 into main Apr 25, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-670-fix-dnd-firefox branch April 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mki-c2c mki-c2c mki-c2c approved these changes

@tkohr tkohr Awaiting requested review from tkohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlitaBernachot @mki-c2c