GSLUX-655: Draggable 3d layers #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-655-Draggable3dLayers/ |
AlitaBernachot
force-pushed
the
GSLUX-655-Draggable3dLayers
branch
from
f92731b
to
825dfde
Compare
Merged
|
hello @AlitaBernachot. 3d layers shall not be draggable, I disabled the drag capability on purpose. 3d stacking does not work in prod, and furthermore there is not point in stacking 3d layers, they cannot be one on top of another. |
tkohr
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Thanks, @AlitaBernachot ! Not sure what effect this should have on the map, but it works fine in the layer manager and does not cause errors as they occur on current prod. Tested in v4 and v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-655
Description
NB: this PR need #79 to be merged first.
There is no Permalink to check if the layers have been reordered, but this can be tested with the Vue Devtools plugin by inspecting the content of the map store in the Pinia tab.