GSLUX-569: Time layers permalink (parent GSLUX-594) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-594-TimeSelectionsLayers/ |
AlitaBernachot
force-pushed
the
GSLUX-594-TimeSelectionsLayers
branch
from
0b1fbf5
to
6ef5bc2
Compare
AlitaBernachot
force-pushed
the
GSLUX-594-TimeSelectionsLayers
branch
from
6ef5bc2
to
fc747d4
Compare
AlitaBernachot
force-pushed
the
GSLUX-594-TimeSelectionsLayers
branch
from
acb3698
to
0c338fe
Compare
tkohr
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Impressive work! Thanks for this new dev @AlitaBernachot ! I have no comments regarding the code, just noticed that the date does not seem to be updated when using the datepicker widget with one date (value type). Maybe you could take a look at this on your side, before merging. The e2e only tests the range widget if I saw correctly.
|
@tkohr Indeed, I wasn't e2e testing the datepicker in value mode, I would have noticed the datepicker wasn't working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-569
Description
Handle time layers in permalink, plus UI in layer-item.
There are 4 types of time components :
Theme fixtures have been updated with new time layers for tests.
⚠️ Adding time layers on map will be done in another PR.
timeparam in permalink (and localstorage)layer-time-datepickerandlayer-time-sliderluxonin package.json to help with date formatting':'ullistScreenshots
Slider value
Slider range
TODO, in GSLUX-649
Datepicker range
Datepicker value
Run in dev
👉 If you want to compare behavior in v3 dev mode, please update your db with commit: https://github.com/camptocamp/luxembourg_dev_db/tree/time_layers