Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-754: Add info-panel #168

Merged
merged 1 commit into from
Nov 18, 2024
Merged

GSLUX-754: Add info-panel #168

merged 1 commit into from
Nov 18, 2024

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Oct 28, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-754

Description

PR adds the info panel (with no functionality).

Note: The translation was recreated to prevent an html tag in it (italics are lost for now). Its key was shortened because a multi-line key did not work on my side.

Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-754-info-panel/

Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general remark on e2e tests:

we are writing very small e2e tests with only one test per page load, the recommendations are to chain a couple of tests of a related scenario.

In order not to increase the e2e test time to unacceptably long durations, we should try to find the good balance between tests case isolation and complete complex tests scenarios.
to be followed...

But please merge the PR first and we then think about further test strategies.

cy.get('[data-cy="layerPanel"]').should('not.exist')
})

describe('When clicking on layers panel button', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected as a first test the click on the info close button, then click on the layer button

@tkohr tkohr merged commit 921e184 into main Nov 18, 2024
2 checks passed
@tkohr tkohr deleted the GSLUX-754-info-panel branch November 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants