clarify naming of method to avoid side effect where getLayer is calle…

…d, without wanting to create it.
Geoportail-Luxembourg · Aug 22, 2023 · 19cfb89 · 19cfb89
1 parent d4de48b
commit 19cfb89
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/composables/map/ol.composable.ts b/src/composables/map/ol.composable.ts
@@ -186,7 +186,7 @@ export default function useOpenLayers() {
   }
 
   function addLayer(olMap: OlMap, layer: Layer) {
-    const baseLayer = getLayerFromCache(layer)
+    const baseLayer = getOrCreateLayer(layer)
     olMap.addLayer(baseLayer)
   }
 
@@ -234,9 +234,7 @@ export default function useOpenLayers() {
     layersCache.set(id, layer)
   }
 
-  function getLayerFromCache(
-    layer: Layer | undefined | null
-  ): BaseLayer | null {
+  function getOrCreateLayer(layer: Layer | undefined | null): BaseLayer | null {
     if (layer === null || layer === undefined) return null
     const id = layer.id
 
@@ -250,6 +248,15 @@ export default function useOpenLayers() {
     }
   }
 
+  function getLayerFromCache(
+    layer: Layer | undefined | null
+  ): BaseLayer | null {
+    if (layer === null || layer === undefined) return null
+    const id = layer.id
+
+    return layersCache.get(id)
+  }
+
   function applyOnBgLayer(
     olMap: OlMap,
     callbackFunction: (bgLayer: BaseLayer) => void