Migrate staging changes to main branch #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only focused on `UtaDatabase` for now * `alt_pos_change` was renamed to `pos_change`
Addresses part of #224 * `transcript_to_genomic_coordinates` renamed to `tx_segment_to_genomic` * `genomic_to_transcript_exon_coordinates` renamed to `genomic_to_tx_segment`
addresses #224 * initial work for cleaning up exon coord data retrieval
addresses #224 * Use `ExonGenomicCoordsMapper._get_all_exon_coords` instead
* include `ord` in `get_alt_ac_start_or_end` response. This represents the exon number (0-based)
…351) * include include `ord` in `UtaDatabase.get_tx_exon_aln_v_data` response. This represents the exon number (0-based)
Close #345 and #332 * Update and fix bugs in`ExonGenomicCoordsMapper` * Change output for public methods in `ExonGenomicCoordsMapper` (leverage VRS Sequence Location and improve structure for transcript segment data). Renamed `warnings` to `errors`. * Resolve offset / genomic location bugs (#345 and #332) * Remove `mane_transcript` instance variable and use `mane_transcript_mappings` instead. * Refactor code that was unnecessary or extra. * Rename arguments in `genomic_to_tx_segment`: `alt_ac` -> `genomic_ac`, `genomic_start` -> ` seg_start_genomic`, `genomic_end` -> `seg_end_genomic` * pin `ga4gh.vrs` to `2.0.0a10` * Remove `get_genes_and_alt_acs` from `UtaDatabase`. Moved this to `ExonGenomicCoordsMapper` and renamed to `_get_genomic_ac_gene`. Will return single gene since genomic accessions are not needed anymore. --------- Co-authored-by: Jeremy Arbesfeld <jarbesfeld@gmail.com>
close #329 * When lifting over to GRCh38 assembly, genomic accession and genomic position should be updated accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All previous commits were already approved.