Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reorder classes and methods in exon_genomic_coords module #358

Merged
merged 3 commits into from
Aug 23, 2024
Merged

refactor: reorder classes and methods in exon_genomic_coords module #358

merged 3 commits into from
Aug 23, 2024

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Aug 20, 2024 •
edited
Loading

Addresses #224

  • No code was changed in the classes or methods.

@korikuzma korikuzma added priority:medium Medium priority cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced labels Aug 20, 2024
@korikuzma korikuzma self-assigned this Aug 20, 2024
jsstevenson
jsstevenson previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for history purposes it'd be good to specify in the squash message that a lot of this commit is just moving stuff around

@korikuzma korikuzma changed the title refactor: organize classes and methods in exon_genomic_coords module refactor: reorder classes and methods in exon_genomic_coords module Aug 21, 2024
@korikuzma korikuzma changed the title refactor: reorder classes and methods in exon_genomic_coords module refactor: reorder classes and methods in exon_genomic_coords module Aug 21, 2024
@korikuzma korikuzma added priority:low Low priority and removed priority:medium Medium priority labels Aug 21, 2024
@korikuzma
refactor: reorder classes and methods in exon_genomic_coords module
1539ccc 
addresses #224

* No code was changed in the classes or methods
Base automatically changed from rename-exon-coord to main August 22, 2024 14:40
@korikuzma korikuzma dismissed jsstevenson’s stale review August 22, 2024 14:40

The base branch was changed.

@korikuzma korikuzma merged commit 43979e3 into main Aug 23, 2024
12 checks passed
@korikuzma korikuzma deleted the organize-mapper branch August 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarbesfeld jarbesfeld jarbesfeld approved these changes

@jsstevenson jsstevenson jsstevenson left review comments

Assignees

@korikuzma korikuzma

Labels
cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korikuzma @jsstevenson @jarbesfeld