build: update pydantic to v2 and remove GeneNormalizer class
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
priority:high
|
We might want to bump the patch version since this will cause breaking changes |
jsstevenson
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #188 . This work is needed for plenary. Our collaborators at the Broad will need to re-run the GK pilot data using variation-normalizer, which has cool-seq-tool as a dependency. They will be blocked until this is released.
I'm creating a separate branch since this comments out some code that isn't needed for plenary (
/get_mapped_mane_data)Notes:
get_mapped_mane_datasince we do not have a Chromosome Location in VRS 2.0-alpha yet. Will be added back in Removeget_mapped_mane_data#194 . I still left gene-normalizer dependency + instance variable in CoolSeqTool since it will be added back