Skip to content

Commit

Permalink
Improved how values are handled in update function. Added more tests …
Browse files Browse the repository at this point in the history
…and more code sniffing
  • Loading branch information
Garethp committed May 10, 2016
1 parent 54cc502 commit 0eced0d
Show file tree
Hide file tree
Showing 30 changed files with 93 additions and 53 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
[{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["8d85c529-8593-4bb0-b2d8-1c4b90f3c6f4"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=45f7593f7fc74529940a49eb532f4e4a; expires=Wed, 10-May-2017 09:03:51 GMT; path=\/; HttpOnly"],"x-EwsHandler":["CreateItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["AM2PR07CA0015"],"Date":["Tue, 10 May 2016 09:03:51 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:CreateItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:CreateItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><m:Items><t:CalendarItem><t:ItemId Id=\"AAMkAGRmOGJjZTc0LWQ0ZWUtNDliZC1hYjQ1LTkyODM1NjFhMGIzNwBGAAAAAAAdsEfFUCwSRaf4+E1agVdfBwA4JiVRwOF7SbQybW1zR3q0AAAAAAENAAA4JiVRwOF7SbQybW1zR3q0AAAtPQCHAAA=\" ChangeKey=\"DwAAABYAAAA4JiVRwOF7SbQybW1zR3q0AAAtQSfU\"\/><\/t:CalendarItem><\/m:Items><\/m:CreateItemResponseMessage><\/m:ResponseMessages><\/m:CreateItemResponse><\/s:Body><\/s:Envelope>"},{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["ea746c79-6489-48f2-86d0-55d434ee6c80"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=76f780ab80864c8ab92562d6152430eb; expires=Wed, 10-May-2017 09:03:52 GMT; path=\/; HttpOnly"],"x-EwsHandler":["DeleteItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["AM2PR07CA0015"],"Date":["Tue, 10 May 2016 09:03:51 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:DeleteItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:DeleteItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><\/m:DeleteItemResponseMessage><\/m:ResponseMessages><\/m:DeleteItemResponse><\/s:Body><\/s:Envelope>"}]
[{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["0daf7cb1-a7c9-4641-b80c-fcfd755d54f4"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=b65feb9f22ef4ded872a11ea9e99c303; expires=Wed, 10-May-2017 10:18:10 GMT; path=\/; HttpOnly"],"x-EwsHandler":["CreateItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["VI1PR08CA0025"],"Date":["Tue, 10 May 2016 10:18:09 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:CreateItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:CreateItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><m:Items><t:CalendarItem><t:ItemId Id=\"AAMkAGRmOGJjZTc0LWQ0ZWUtNDliZC1hYjQ1LTkyODM1NjFhMGIzNwBGAAAAAAAdsEfFUCwSRaf4+E1agVdfBwA4JiVRwOF7SbQybW1zR3q0AAAAAAENAAA4JiVRwOF7SbQybW1zR3q0AAAtPQCPAAA=\" ChangeKey=\"DwAAABYAAAA4JiVRwOF7SbQybW1zR3q0AAAtQSfk\"\/><\/t:CalendarItem><\/m:Items><\/m:CreateItemResponseMessage><\/m:ResponseMessages><\/m:CreateItemResponse><\/s:Body><\/s:Envelope>"},{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["95979ca1-cd35-4e49-b9d1-be5985349fb1"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=722926a0692540ca9bed44c815a27e69; expires=Wed, 10-May-2017 10:18:10 GMT; path=\/; HttpOnly"],"x-EwsHandler":["DeleteItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["VI1PR08CA0025"],"Date":["Tue, 10 May 2016 10:18:09 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:DeleteItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:DeleteItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><\/m:DeleteItemResponseMessage><\/m:ResponseMessages><\/m:DeleteItemResponse><\/s:Body><\/s:Envelope>"}]

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
[{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["01ded5ec-b45a-4681-bac7-15228c2ca7e0"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=4e271ba587f2442c919340692ef2c7b3; expires=Wed, 10-May-2017 09:03:52 GMT; path=\/; HttpOnly"],"x-EwsHandler":["CreateItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["AM2PR07CA0016"],"Date":["Tue, 10 May 2016 09:03:52 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:CreateItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:CreateItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><m:Items><t:CalendarItem><t:ItemId Id=\"AAMkAGRmOGJjZTc0LWQ0ZWUtNDliZC1hYjQ1LTkyODM1NjFhMGIzNwBGAAAAAAAdsEfFUCwSRaf4+E1agVdfBwA4JiVRwOF7SbQybW1zR3q0AAAAAAENAAA4JiVRwOF7SbQybW1zR3q0AAAtPQCIAAA=\" ChangeKey=\"DwAAABYAAAA4JiVRwOF7SbQybW1zR3q0AAAtQSfW\"\/><\/t:CalendarItem><\/m:Items><\/m:CreateItemResponseMessage><\/m:ResponseMessages><\/m:CreateItemResponse><\/s:Body><\/s:Envelope>"},{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["a14fc43f-d20a-4865-a1c5-81e082840b93"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=3f05a289599d4cea980e1edab7322f2c; expires=Wed, 10-May-2017 09:03:52 GMT; path=\/; HttpOnly"],"x-EwsHandler":["DeleteItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["AM2PR07CA0016"],"Date":["Tue, 10 May 2016 09:03:52 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:DeleteItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:DeleteItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><\/m:DeleteItemResponseMessage><\/m:ResponseMessages><\/m:DeleteItemResponse><\/s:Body><\/s:Envelope>"}]
[{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["ed30bb47-f348-47d5-a9b4-c2e283fa6e20"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=5b499e3c4e7747e38d3dd7844081a986; expires=Wed, 10-May-2017 10:18:10 GMT; path=\/; HttpOnly"],"x-EwsHandler":["CreateItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["VI1PR08CA0022"],"Date":["Tue, 10 May 2016 10:18:10 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:CreateItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:CreateItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><m:Items><t:CalendarItem><t:ItemId Id=\"AAMkAGRmOGJjZTc0LWQ0ZWUtNDliZC1hYjQ1LTkyODM1NjFhMGIzNwBGAAAAAAAdsEfFUCwSRaf4+E1agVdfBwA4JiVRwOF7SbQybW1zR3q0AAAAAAENAAA4JiVRwOF7SbQybW1zR3q0AAAtPQCQAAA=\" ChangeKey=\"DwAAABYAAAA4JiVRwOF7SbQybW1zR3q0AAAtQSfm\"\/><\/t:CalendarItem><\/m:Items><\/m:CreateItemResponseMessage><\/m:ResponseMessages><\/m:CreateItemResponse><\/s:Body><\/s:Envelope>"},{"error":false,"statusCode":200,"headers":{"Cache-Control":["private"],"Transfer-Encoding":["chunked"],"Content-Type":["text\/xml; charset=utf-8"],"Server":["Microsoft-IIS\/8.0"],"request-id":["166b5992-4fc1-43eb-a053-370f55db2a42"],"X-CalculatedBETarget":["DB5PR0401MB1877.eurprd04.prod.outlook.com"],"X-BackEndHttpStatus":["200"],"Set-Cookie":["exchangecookie=0e6d0f78f5a049deb908fe31775c07bb; expires=Wed, 10-May-2017 10:18:10 GMT; path=\/; HttpOnly"],"x-EwsHandler":["DeleteItem"],"X-AspNet-Version":["4.0.30319"],"X-DiagInfo":["DB5PR0401MB1877"],"X-BEServer":["DB5PR0401MB1877"],"X-Powered-By":["ASP.NET"],"X-FEServer":["VI1PR08CA0022"],"Date":["Tue, 10 May 2016 10:18:10 GMT"]},"body":"<?xml version=\"1.0\" encoding=\"utf-8\"?><s:Envelope xmlns:s=\"http:\/\/schemas.xmlsoap.org\/soap\/envelope\/\"><s:Header><h:ServerVersionInfo MajorVersion=\"15\" MinorVersion=\"1\" MajorBuildNumber=\"492\" MinorBuildNumber=\"18\" Version=\"V2016_04_13\" xmlns:h=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\"\/><\/s:Header><s:Body><m:DeleteItemResponse xmlns:m=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/messages\" xmlns:xsd=\"http:\/\/www.w3.org\/2001\/XMLSchema\" xmlns:xsi=\"http:\/\/www.w3.org\/2001\/XMLSchema-instance\" xmlns:t=\"http:\/\/schemas.microsoft.com\/exchange\/services\/2006\/types\"><m:ResponseMessages><m:DeleteItemResponseMessage ResponseClass=\"Success\"><m:ResponseCode>NoError<\/m:ResponseCode><\/m:DeleteItemResponseMessage><\/m:ResponseMessages><\/m:DeleteItemResponse><\/s:Body><\/s:Envelope>"}]
Loading

0 comments on commit 0eced0d

Please sign in to comment.