Add specific exception if pad is not publicly available (#68)

Gared · Oct 9, 2024 · 9b2d64d · 9b2d64d
1 parent 33b130d
commit 9b2d64d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/Exception/EtherpadServiceNotPublicException.php b/src/Exception/EtherpadServiceNotPublicException.php
@@ -0,0 +1,10 @@
+<?php
+declare(strict_types=1);
+
+namespace Gared\EtherScan\Exception;
+
+use Exception;
+
+class EtherpadServiceNotPublicException extends Exception
+{
+}
diff --git a/src/Service/ScannerService.php b/src/Service/ScannerService.php
@@ -8,6 +8,7 @@
 use Exception;
 use Gared\EtherScan\Api\GithubApi;
 use Gared\EtherScan\Exception\EtherpadServiceNotFoundException;
+use Gared\EtherScan\Exception\EtherpadServiceNotPublicException;
 use Gared\EtherScan\Model\VersionRange;
 use GuzzleHttp\Client;
 use GuzzleHttp\Cookie\CookieJar;
@@ -189,9 +190,6 @@ private function scanAdmin(ScannerServiceCallbackInterface $callback): void
         $this->getAdmin('user', 'changeme1', $callback);
     }
 
-    /**
-     * @throws EtherpadServiceNotFoundException
-     */
     private function scanPad(ScannerServiceCallbackInterface $callback): void
     {
         $callback->onScanPadStart();
@@ -529,7 +527,7 @@ private function handleClientVarsResponse(
         $data = $data[1];
         $accessStatus = $data['accessStatus'] ?? null;
         if ($accessStatus === 'deny') {
-            $callback->onScanPadException(new EtherpadServiceNotFoundException('Pads are not publicly accessible'));
+            $callback->onScanPadException(new EtherpadServiceNotPublicException('Pads are not publicly accessible'));
             return;
         }
 
@@ -582,7 +580,7 @@ private function doSocketWebsocket(
             if ($result !== null && is_array($result->data)) {
                 $accessStatus = $result->data['accessStatus'] ?? null;
                 if ($accessStatus === 'deny') {
-                    $callback->onScanPadException(new EtherpadServiceNotFoundException('Pads are not publicly accessible'));
+                    $callback->onScanPadException(new EtherpadServiceNotPublicException('Pads are not publicly accessible'));
                     return;
                 }
                 $data = $result->data;