Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH enable noise fields and fix drawing bugz #79

Merged
merged 11 commits into from
Nov 15, 2023
Merged

ENH enable noise fields and fix drawing bugz #79

merged 11 commits into from
Nov 15, 2023

Conversation

beckermr
Copy link
Collaborator

@beckermr beckermr commented Nov 5, 2023 •
edited
Loading

This PR

  • adds noise fields
  • adds tests of drawing
  • fixes some bugs that were flushed out by the previous two things

@beckermr beckermr changed the title WIP enable noise fields and fix drawing bugz ENH enable noise fields and fix drawing bugz Nov 5, 2023
@beckermr beckermr marked this pull request as ready for review November 10, 2023 20:30
@beckermr beckermr assigned beckermr and ismael-mendoza and unassigned beckermr Nov 10, 2023
@beckermr
Copy link
Collaborator Author

@ismael-mendoza this one is ready for review!

@ismael-mendoza
Copy link
Collaborator

Thanks @beckermr ! Looking at this today :-)

ismael-mendoza
ismael-mendoza approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckermr beckermr merged commit 50514dd into GalSim-developers:main Nov 15, 2023
3 checks passed
@beckermr beckermr deleted the noise-fields branch November 15, 2023 17:38
@beckermr beckermr mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismael-mendoza ismael-mendoza ismael-mendoza approved these changes

Assignees

@ismael-mendoza ismael-mendoza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckermr @ismael-mendoza