VisualiserTool : Visualise value #6159
Open
+1,795
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment in the code indicates, this is needed to fix something that MSVC is doing that prevents setting the polygon mode with the original value obtained from `glGetIntegerv` from working. I've verified that `polygonMode is in fact a valid value. Initializing the varaible seems to prevent whatever compiler optimization is causing the value to appear as an "invalid enum".
ericmehl
force-pushed
the
visualiserValueTool
branch
from
c04932d
to
f6c4118
Compare
We instead add a stroke-like effect to always-white text so it is visible on a full range of background colors without needing user modification.
ericmehl
force-pushed
the
visualiserValueTool
branch
from
df8271c
to
7f92ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
CsVisualiseValuetool contributed by @proberts-cinesite in #6142 in the form of a slightly more generalised tool calledVisualiserTool. We plan to add more visualisation modes to this tool, rather than as separate tools.Here I've reformatted the code to fit our conventions, but tried not to make any other changes not needed to get the tool ready. The biggest difference is probably in how we typically do
constvalues - hopefully I've gotten those right and didn't lose anyconst-ness.Checklist