Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#297] SMS 인증제 Textfield 컴포넌트 퍼블리싱 #298

Merged
merged 7 commits into from
May 28, 2024

Conversation

Ethen1264
Copy link
Contributor

💡 배경 및 개요

SMS 인증제 Textfield 컴포넌트를 퍼블리싱 했습니다.

스크린샷 2024-05-25 오후 12 32 12

Resolves: #297

📃 작업내용

SMS 인증제 Textfield 컴포넌트를 퍼블리싱 했습니다.
input의 아이콘은 컴포넌트를 호출 할 때 icon을 props로 넘겨기게 제작 했습니다.

@Ethen1264 Ethen1264 added the 3️⃣ Priority: Low 우선순위 - 하 label May 25, 2024
@Ethen1264 Ethen1264 self-assigned this May 25, 2024
Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sms ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:31am

Copy link
Member

@chanwoo00106 chanwoo00106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 pr 리뷰 늦어져서 미안해...
늦었지만 지금이라도 하자면

packages/shared/src/atoms/Textfield/index.tsx Outdated Show resolved Hide resolved
packages/shared/src/icons/File.tsx Show resolved Hide resolved
packages/shared/src/atoms/Textfield/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@chanwoo00106 chanwoo00106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ethen1264 Ethen1264 merged commit dee8453 into develop May 28, 2024
3 checks passed
@mini-aron mini-aron mentioned this pull request May 30, 2024
@chanwoo00106 chanwoo00106 deleted the feature/textfield branch July 13, 2024 06:06
@chanwoo00106 chanwoo00106 mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3️⃣ Priority: Low 우선순위 - 하
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMS 인증제 Textfield 만들기
2 participants