Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moussaab/teams #57

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Moussaab/teams #57

merged 11 commits into from
Dec 8, 2023

Conversation

MoussaabBadla
Copy link
Member

No description provided.

Brivan-26
Brivan-26 previously approved these changes Dec 5, 2023
Copy link
Member

@Brivan-26 Brivan-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work and for respecting the project architecture.
Unit tests MUST be added for new features

app/Models/User.php Outdated Show resolved Hide resolved
app/Http/Repositories/TeamRepository.php Outdated Show resolved Hide resolved
app/Http/Repositories/TeamRepository.php Outdated Show resolved Hide resolved
app/Http/Repositories/TeamRepository.php Show resolved Hide resolved
app/Http/Repositories/TeamRepository.php Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should seed some users that belong to some teams.

routes/api.php Outdated Show resolved Hide resolved
app/Http/Controllers/API/AdminController.php Show resolved Hide resolved
app/Http/Middleware/EnsureTeamExists.php Outdated Show resolved Hide resolved
app/Http/Middleware/EnsureTeamExists.php Outdated Show resolved Hide resolved
@Brivan-26
Copy link
Member

Brivan-26 commented Dec 5, 2023

The request changes should be addressed and the unit tests for new functionalities must be written before merging the PR

@Brivan-26 Brivan-26 self-requested a review December 5, 2023 21:17
@Brivan-26 Brivan-26 dismissed their stale review December 5, 2023 21:18

Accidentlly approved.

Copy link
Member

@Brivan-26 Brivan-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done! Few changes needed

tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/GetTeamByIdTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/RemoveTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/RemoveTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/RemoveTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/UpdateTeamTest.php Outdated Show resolved Hide resolved
Copy link
Member

@Brivan-26 Brivan-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the last reviews.
Few more lines need to be deleted and the PR is ready to get merged.

tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/AddTeamMemberTest.php Outdated Show resolved Hide resolved
tests/Feature/Admin/Teams/GetTeamByIdTest.php Outdated Show resolved Hide resolved
MoussaabBadla and others added 3 commits December 8, 2023 16:21
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
Copy link
Member

@Brivan-26 Brivan-26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Thanks for contributing

@Brivan-26 Brivan-26 merged commit 4885c04 into GDGAlgiers:dev Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants