-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moussaab/teams #57
Moussaab/teams #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work and for respecting the project architecture.
Unit tests MUST be added for new features
database/seeders/UserSeeder.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should seed some users that belong to some teams.
The request changes should be addressed and the unit tests for new functionalities must be written before merging the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done! Few changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the last reviews.
Few more lines need to be deleted and the PR is ready to get merged.
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
Co-authored-by: Mohamed Abdessamed <75367288+Brivan-26@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Thanks for contributing
No description provided.