Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure shared access on api create #23

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

lebalz
Copy link
Contributor

@lebalz lebalz commented Nov 11, 2024

make shared access configurable on doc root creation

@SilasBerger
Copy link
Contributor

LGTM 👍

One thought (although not directly related to this PR): Do you think we might need to extend the shared access concept to a user- and group-based solution like we do with "regular" permissions? That way, for instance, an admin could create a CmsText document and share it only with student X, e.g. to provide a grade.

@lebalz lebalz merged commit 6bb6264 into main Nov 18, 2024
1 check passed
@lebalz lebalz deleted the fix/configure-shared-access-on-create branch November 18, 2024 08:58
@lebalz
Copy link
Contributor Author

lebalz commented Nov 18, 2024

@SilasBerger

One thought (although not directly related to this PR): Do you think we might need to extend the shared access concept to a user- and group-based solution like we do with "regular" permissions? That way, for instance, an admin could create a CmsText document and share it only with student X, e.g. to provide a grade.

This is already the case and works (at least with the implementation of #25). The rules are

  • a user can have max. it's user permission for a shared document
  • the shared doc permission on the root describes the max. access to a document (so user has RW, but shared is RO - the user which is not the author, has only RO access)

So a configuration for the CmsText couldshould already work:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants