Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish with GH actions #10

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Publish with GH actions #10

merged 1 commit into from
Apr 25, 2024

Conversation

rokostik
Copy link
Collaborator

This PR adds the ability to publish releases with GH actions.

@rokostik rokostik requested a review from gzuidhof April 15, 2024 10:58
@gzuidhof
Copy link
Contributor

I imagine we'll also have to add some secret to the repo? I'll make you an admin for this repo.

Copy link
Contributor

@gzuidhof gzuidhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rokostik
Copy link
Collaborator Author

I imagine we'll also have to add some secret to the repo? I'll make you an admin for this repo.

No, PIP actually has something called trusted publishers so I added this repo to our PIP project and it should work without any additional secrets.

@rokostik rokostik merged commit 1595bd4 into main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants