Add example #2
Merged
Add example #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denagyantal
suggested changes
Jan 23, 2024
gzuidhof
approved these changes
Jan 23, 2024
example/main.go
Outdated
| if siteverifyEndpoint != "" { | ||
| opts = append(opts, friendlycaptcha.WithSiteverifyEndpoint(siteverifyEndpoint)) // optional, defaults to "global" | ||
| } | ||
| frcClient := friendlycaptcha.NewClient(opts...) |
There was a problem hiding this comment.
Not so much a comment on this example, more on the SDK in general.
I think it may be worth considering returning an error as well here. Right now there is no part of the setup that can go wrong, but perhaps in the future we can add some sanity checks for the values entered - and it would be a breaking change if we wanted to change that.
What do you think?
Each of the Options could return an error.
There was a problem hiding this comment.
That's a really good idea. Implemented in 3ff7bdc. Already looks better because we don't panic if user forgot to set API key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/FriendlyCaptcha/friendly-captcha/issues/720
Closes https://github.com/FriendlyCaptcha/friendly-captcha/issues/870