UpdateSObject - Added option to specify API version #33
Conversation
WalkthroughThe recent update to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UpdateSObject
participant SalesforceAPI
User->>UpdateSObject: Call UpdateSObject with ApiVersion
UpdateSObject->>SalesforceAPI: Send request with specified ApiVersion
SalesforceAPI-->>UpdateSObject: Return response
UpdateSObject-->>User: Return result
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- Frends.Salesforce.UpdateSObject/CHANGELOG.md (1 hunks)
- Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject.Tests/UnitTests.cs (16 hunks)
- Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/Definitions/Input.cs (1 hunks)
- Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject.csproj (1 hunks)
- Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/UpdateSObject.cs (1 hunks)
Additional comments not posted (22)
Frends.Salesforce.UpdateSObject/CHANGELOG.md (1)
3-5: Changelog update is accurate.The changelog correctly documents the new feature allowing users to specify the Salesforce API version. This is a necessary update for transparency and version tracking.
Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject.csproj (1)
5-5: Version increment is appropriate.The version number change from 1.0.0 to 2.0.0 correctly reflects the breaking changes introduced in this update.
Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/Definitions/Input.cs (2)
12-12: Documentation clarity improved.The updated comment for the
Domainproperty clarifies the dynamic nature of the version number in the URL.
19-24: NewApiVersionproperty enhances flexibility.The addition of the
ApiVersionproperty allows users to specify the Salesforce API version, improving compatibility with different environments.Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject/UpdateSObject.cs (1)
39-39: Dynamic API versioning implemented.The use of
input.ApiVersionin constructing theRestClientURL allows for flexible API versioning, which is a valuable enhancement.Frends.Salesforce.UpdateSObject/Frends.Salesforce.UpdateSObject.Tests/UnitTests.cs (17)
85-89: Test update forApiVersionis comprehensive.The inclusion of the
ApiVersionparameter in theUpdateAccountTestensures that the new functionality is thoroughly tested.
91-96: New test for default API version behavior.The
UpdateAccountTest_WithoutSpecifiedApiVersiontest effectively verifies the default behavior when the API version is not specified.
118-118: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theUpdateContactTestensures consistency across test cases.
155-155: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theUpdateCaseTestensures consistency across test cases.
188-188: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theGetReturnedAccessTokenTestensures consistency across test cases.
200-200: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theEmptyAccessToken_ThrowTestensures consistency across test cases.
222-222: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theEmptyDomain_ThrowTestensures consistency across test cases.
243-243: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theEmptyId_ThrowTestensures consistency across test cases.
264-264: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theEmptyJson_ThrowTestensures consistency across test cases.
285-285: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theEmptyType_ThrowTestensures consistency across test cases.
306-306: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theInvalidDomain_ThrowTestensures consistency across test cases.
332-332: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theExampleDomain_ThrowTestensures consistency across test cases.
358-358: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theInvalidObjectType_ThrowTestensures consistency across test cases.
385-385: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theInvalidSecretOAuth_ThrowTestensures consistency across test cases.
412-412: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theInvalidId_ThrowTestensures consistency across test cases.
435-435: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theInvalidJson_ThrowTestensures consistency across test cases.
457-457: ConsistentApiVersionusage in tests.The addition of
ApiVersionin theNotFoundId_ThrowTestensures consistency across test cases.
Closes #18 . Major version bump to 2.0.0. You can now specify API-version in the input-section. If left empty, the latest version as of today will be used (v61.0).
Summary by CodeRabbit
New Features
Bug Fixes
Chores