-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeleteSObject - Added option to specify API version #32
base: main
Are you sure you want to change the base?
DeleteSObject - Added option to specify API version #32
Conversation
Warning Rate limit exceeded@FrendsSarlinS has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 39 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeleteSObject
participant SalesforceAPI
User->>DeleteSObject: Request to delete object with API version
DeleteSObject->>SalesforceAPI: Call DeleteSObject with specified API version
SalesforceAPI-->>DeleteSObject: Response with deletion status
DeleteSObject-->>User: Return deletion status
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- Frends.Salesforce.DeleteSObject/CHANGELOG.md (1 hunks)
- Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject.Tests/UnitTests.cs (13 hunks)
- Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/Definitions/Input.cs (1 hunks)
- Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/DeleteSObject.cs (1 hunks)
- Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject.csproj (1 hunks)
Additional comments not posted (5)
Frends.Salesforce.DeleteSObject/CHANGELOG.md (1)
3-5
: Changelog update is accurate.The changelog entry correctly reflects the new feature allowing specification of the Salesforce API version.
Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject.csproj (1)
5-5
: Version update is appropriate.The version bump to 2.0.0 is suitable given the breaking changes introduced by allowing API version specification.
Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/Definitions/Input.cs (1)
19-24
: Addition ofApiVersion
property is well-implemented.The
ApiVersion
property provides flexibility by allowing users to specify the API version, with a sensible default value of "v61.0".Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject/DeleteSObject.cs (1)
36-36
: Dynamic API version usage is well-implemented.Using
input.ApiVersion
in theRestClient
URL enhances flexibility by allowing different API versions to be specified.Frends.Salesforce.DeleteSObject/Frends.Salesforce.DeleteSObject.Tests/UnitTests.cs (1)
59-64
: Unit test updates are comprehensive.The inclusion of the
ApiVersion
parameter in tests and the addition of new test cases ensure thorough coverage of the new functionality.Also applies to: 66-72, 86-86, 108-111, 129-129, 141-141, 162-162, 183-183, 204-204, 225-225, 249-249, 274-274, 299-299, 321-321
Closes #20 . Major version bump to 2.0.0. You can now specify API-version in the input-section. If left empty, the latest version as of today will be used (v61.0).
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores