Options.NotifyAfter fix.

[ttossavainen]

#43

Summary by CodeRabbit

• New Features

  • Introduced dynamic adjustment for the NotifyAfter property, enhancing row notification accuracy during bulk insert operations.

• Bug Fixes

  • Improved error reporting by updating exception messages to reflect the actual state of the NotifyAfter property.

• Documentation

  • Updated documentation for the NotifyAfter property to clarify its dynamic behavior and usage.

• Chores

  • Updated project version to 2.2.0 to reflect the latest enhancements and fixes.

[coderabbitai]

Warning

Rate limit exceeded

@ttossavainen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4ae5fbb and 21f22c5.

Walkthrough

The Frends.MicrosoftSQL.BulkInsert module has been updated to version 2.2.0, released on September 10, 2024. The primary enhancement is the dynamic adjustment of the Options.NotifyAfter property based on the total row count, which improves the accuracy of the rowsCopied value during bulk insert operations. Additionally, the documentation for the NotifyAfter property has been clarified, and the project file version has been updated.

Changes

Files	Change Summary
Frends.MicrosoftSQL.BulkInsert/CHANGELOG.md	Added version entry for 2.2.0, detailing changes to Options.NotifyAfter property.
Frends.MicrosoftSQL.BulkInsert/Frends.MicrosoftSQL.BulkInsert/BulkInsert.cs	Modified ExecuteHandler to set NotifyAfter dynamically based on dataset size; updated exception message for clarity.
Frends.MicrosoftSQL.BulkInsert/Frends.MicrosoftSQL.BulkInsert/Definitions/Options.cs	Updated documentation for NotifyAfter property to reflect dynamic behavior and clarify notification conditions.
Frends.MicrosoftSQL.BulkInsert/Frends.MicrosoftSQL.BulkInsert/Frends.MicrosoftSQL.BulkInsert.csproj	Changed version number from 2.1.0 to 2.2.0.
Frends.MicrosoftSQL.BulkInsert/Frends.MicrosoftSQL.BulkInsert.Tests/UnitTests.cs	Modified test methods to use a dynamic NotifyAfter value instead of a static one, introducing variability in notifications.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BulkInsert
    participant SqlBulkCopy

    User->>BulkInsert: Initiate bulk insert
    BulkInsert->>SqlBulkCopy: Set NotifyAfter dynamically
    SqlBulkCopy->>BulkInsert: Notify after processing rows
    BulkInsert->>User: Return result

Loading

🐰 In the garden, where data flows,
A rabbit hops where the SQL grows.
With NotifyAfter set just right,
It counts the rows, a joyful sight!
Version two point two, oh what a cheer,
Hopping along, the changes are here! 🌼

Possibly related PRs

• BulkInsert - add managed identity authentication #52: Involves a transition from System.Data.SqlClient to Microsoft.Data.SqlClient, which is relevant to the main PR's updates regarding the NotifyAfter property and overall functionality of the BulkInsert operations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RikuVirtanen]

Please add tests to test the changes/fixes with other values than just 1.