Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecuteQuery - Removed SqlConnection.ClearAllPools() to make the Task more efficient #42

Merged
merged 6 commits into from
Mar 8, 2024
Merged

ExecuteQuery - Removed SqlConnection.ClearAllPools() to make the Task more efficient #42

merged 6 commits into from
Mar 8, 2024

Conversation

RikuVirtanen
Copy link
Contributor

#41

[1.2.1] - 2024-03-01

Changed

  • Removed finally block from the Task so that the SQLConnection pool is not touched after every call to the ExecuteQuery method.

Updated

  • Newtonsoft.Json to version 13.0.3
  • System.Data.SqlClient to version 4.8.6

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8112027425?pr=42

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8112233460?pr=42

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8112317400?pr=42

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8112332703?pr=42

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8112469721?pr=42

Svenskapojkarna
Svenskapojkarna reviewed Mar 7, 2024
View reviewed changes
...MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/Lib/ExecuteQueryTestBase.cs Outdated Show resolved Hide resolved
...MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/Lib/ExecuteQueryTestBase.cs Outdated Show resolved Hide resolved
...MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/Lib/ExecuteQueryTestBase.cs Outdated Show resolved Hide resolved
...MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/Lib/ExecuteQueryTestBase.cs Outdated Show resolved Hide resolved
...MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/Lib/ExecuteQueryTestBase.cs Outdated Show resolved Hide resolved
Frends.MicrosoftSQL.ExecuteQuery/Frends.MicrosoftSQL.ExecuteQuery.Tests/ScalarUnitTests.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.MicrosoftSQL/actions/runs/8199563680?pr=42

@Svenskapojkarna Svenskapojkarna merged commit 939ed11 into main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Svenskapojkarna Svenskapojkarna Svenskapojkarna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RikuVirtanen @Svenskapojkarna