Code Rabbit fixes

FrendsPlatform · Nov 6, 2024 · 9de5a89 · 9de5a89
1 parent 73f659f
commit 9de5a89
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Definitions/Connection.cs b/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Definitions/Connection.cs
@@ -34,8 +34,9 @@ public class Connection
 
     /// <summary>
     /// Used LDAP protocol version.
+    /// Warning: LDAPv2 is deprecated and has security vulnerabilities. Use LDAPv3 unless absolutely required.
     /// </summary>
-    /// <example>V2</example>
+    /// <example>LDAPVersion.V3</example>
     [DefaultValue(LDAPVersion.V3)]
     public LDAPVersion LDAPProtocolVersion { get; set; }
 

diff --git a/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/SearchObjects.cs b/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/SearchObjects.cs
@@ -43,7 +43,8 @@ public static Result SearchObjects([PropertyTab] Input input, [PropertyTab] Conn
             foreach (var i in input.Attributes)
                 atr.Add(i.Key.ToString());
 
-        var ldapVersion = 0;
+        // Default to v3 as it's the most commonly used version
+        var ldapVersion = 3; 
         switch (connection.LDAPProtocolVersion)
         {
             case LDAPVersion.V2:
@@ -52,6 +53,8 @@ public static Result SearchObjects([PropertyTab] Input input, [PropertyTab] Conn
             case LDAPVersion.V3:
                 ldapVersion = 3;
                 break;
+            default:
+                throw new ArgumentException("Unsupported LDAP protocol version");
         }
 
         try