Emit HID event when keyboard brightness changed via fn+space #53
+90
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain how this event gets interpreted by Gnome? |
|
Unfortunately, proper testing reveals that Linux does not currently handle this HID usage, so I am marking as draft. |
Currently, changing the keyboard backlight brightness via fn+space does not notify the OS in any way. Therefore, OS indicators like GNOME Shell's keyboard backlight slider will show the wrong values. This PR corrects this issue by emitting a "Keyboard Backlight Set Level" HID event on fn+space. Signed-off-by: Jules Bertholet <julesbertholet@quoi.xyz>
Jules-Bertholet
force-pushed
the
keyboard-backlight-hid
branch
from
a451f79
to
3b7718e
Compare
|
This would be really awesome, I think I tried that a few months ago and neither Windows nor Linux supported it :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, changing the keyboard backlight brightness via fn+space does not notify the OS in any way. Therefore, OS indicators like GNOME Shell's keyboard backlight slider will show the wrong values. This PR corrects this issue by emitting a "Keyboard Backlight Set Level" HID event on fn+space. (The backlight brightness is still changed directly in firmware, so functionality in e.g. firmware menu won’t be affected.)