Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForensicError implements std::error::Error by using thiserror::Error #1

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

janstarke
Copy link
Contributor

Every error should implement std::error::Error. For simple conversion, thiserror can be used.

If you do not like having an additional dependency, std::error::Error needs to be implemented manually

Every error should implement std::error::Error. For simple conversion,
thiserror can be used
@SecSamDev
Copy link
Collaborator

SecSamDev commented Feb 8, 2024

I would like to reduce the package dependencies to a minimum. Although thiserror is a very powerful and useful package, in this case std::error::Error could be implemented directly since there are not so many error types.
I don't know how I didn't implement the Error, but you're right, it has to be implemented.
For now we can use thiserror. When I get some time I can look into removing the dependency.

@SecSamDev SecSamDev added the enhancement New feature or request label Feb 8, 2024
@SecSamDev SecSamDev merged commit 8650de4 into ForensicRS:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants