Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MineTinkerReloadEvent #149

Open
4 tasks
Flo56958 opened this issue Jun 15, 2020 · 0 comments
Open
4 tasks

Add MineTinkerReloadEvent #149

Flo56958 opened this issue Jun 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Flo56958
Copy link
Owner

Flo56958 commented Jun 15, 2020

The way the plugin handles reloads is definitely not suitable for the size of it. Some config options do not get reloaded at all, some sometimes and others get reloaded in a really inelegant method call hierarchy.

There should be a Reload-Event called if the Plugin is reloaded so that every class can listen for a reload and deal with it accordingly.

  • Implement MTReloadEvent (maybe look into similar Bukkit Events if available)
  • Rewrite classes like ModManager, Modifiers, LanguageManager, ConfigurationManager, Updater, ChatWriter, ...
  • Use different EventPriorities to have a better reload structure
  • Make the CommandManager reloadable

Plugin Start-up Behaviour:

  1. Load Main-Config File
  2. Init and load Configuration Manager
  3. Init and load Language Manager
  4. Init Mod Manager
  5. Register other Listeners
  6. Load Core Modifiers
  7. Initiate Plugin Reload Event
@Flo56958 Flo56958 added the enhancement New feature or request label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant