Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some issues found by sonarcloud #86

Merged
merged 74 commits into from
Sep 24, 2023
Merged

Address some issues found by sonarcloud #86

merged 74 commits into from
Sep 24, 2023

Conversation

TrentHouliston
Copy link
Member

No description provided.

@TrentHouliston
Address some issues found by sonarcloud
21b6096
@TrentHouliston
Set in variable instead of constructor
74c2b1e
@TrentHouliston
anonymous namespaces do nothing and forwarding references should be f…
23fbdba 
…orwarded
@TrentHouliston
Explicit constructor
aa8eb63
@TrentHouliston
Empty functions and unnecessary inline
5d8d486
@TrentHouliston
More explicit constructors
7b5776d
@TrentHouliston
Explicit constructor
6940861
@TrentHouliston
Pass args directly
dd455f2
@TrentHouliston
Fix constructors
e46032a
@TrentHouliston
Explicit constructors
ff8ac1a
@TrentHouliston
Default constructors for no reason
7f32671
@TrentHouliston
Pointless constructor
c6d763e
@TrentHouliston
explicit
d9aad9c
@TrentHouliston
shadowing
a229f79
@TrentHouliston
shadowing
a43941b
@TrentHouliston
split enum and variable
b60cb15
@TrentHouliston
Make enum class
e2e364f
@TrentHouliston
Fix enum class
b33fbf8
@TrentHouliston
Move powerplant configuration into it's own file and make it simpler
60175b9
@TrentHouliston
.
57f5453
@TrentHouliston
Fix forward
b5bb7af
@TrentHouliston
Put spinlock comment in the while
765ed2e
@TrentHouliston
Empty statement
015887e
@TrentHouliston
This doesn't compile for now
69a2bdf
@TrentHouliston
Explicit constructors and moving defaults
e978952
@TrentHouliston
Use std::lock for multiple mutexes
4121ff1
@TrentHouliston
Const references where possible
9d3101a
@TrentHouliston
take large struct by reference
10944ec
@TrentHouliston
Use transparent comparator
20fc616
@TrentHouliston
Split declaration and variable
842bf26
TrentHouliston
TrentHouliston commented Sep 21, 2023
View reviewed changes
Copy link
Member Author

@TrentHouliston TrentHouliston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder so I can see since last review

@TrentHouliston TrentHouliston enabled auto-merge (squash) September 22, 2023 04:19
Bidski
Bidski requested changes Sep 22, 2023
View reviewed changes
src/CMakeLists.txt Show resolved Hide resolved
Bidski
Bidski previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Bidski Bidski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrentHouliston TrentHouliston merged commit 68e154a into main Sep 24, 2023
15 checks passed
@TrentHouliston TrentHouliston deleted the houliston/sonar branch September 24, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bidski Bidski Bidski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrentHouliston @Bidski