Make SFC and NodeDriver(Auth) upgradable #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
previously approved these changes
Nov 11, 2024
Mike-CZ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes SFC, NodeDriver and NodeDriverAuth upgradable via UUPS. It also removes custom Ownable and Initializable packages and uses the OpenZeppelin instead.
It's up to discussion wether to make NodeDriverAuth also upgradable. At current stage, NodeDriverAuth is being freshly deployed and calledmigrateTomethod at upgrade. This sets the NodeDriver's backend to new NodeDriverAuth and the old implementation is abandoned.migrateTomethod was removed, although it allowed to switch NodeDriver's implementation of Auth contract, the SFC contract itself has no way to change its Auth contract implementation, so it's not doable anyway.