LFVM: move addressInAccessList to getAccessCost
#730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
cb264ee
to
e343d36
Compare
LuisPH3
approved these changes
Sep 5, 2024
LuisPH3
previously approved these changes
Sep 5, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
2 times, most recently
from
96fd6ca
to
6cf6dd6
Compare
simonlechner
previously approved these changes
Sep 5, 2024
LuisPH3
previously approved these changes
Sep 5, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
2 times, most recently
from
cc7d19e
to
f1c0567
Compare
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
f1c0567
to
7cfbdf6
Compare
facuMH
changed the title
addressInAccessListcalculateAccessCost
HerbertJordan
requested changes
Sep 6, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
7cfbdf6
to
2c6e0e6
Compare
facuMH
changed the title
calculateAccessCostaddressInAccessList into genericCall
HerbertJordan
requested changes
Sep 9, 2024
|
Relates to #616 |
LuisPH3
previously approved these changes
Sep 9, 2024
HerbertJordan
requested changes
Sep 12, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
824ad1d
to
9358579
Compare
facuMH
added a commit
that referenced
this pull request
Sep 13, 2024
HerbertJordan
previously approved these changes
Sep 13, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
9358579
to
5c85e26
Compare
HerbertJordan
approved these changes
Sep 13, 2024
facuMH
force-pushed
the
facundo/lfvm-gas-address-in-list
branch
from
bbbc07d
to
fd3ae4b
Compare
facuMH
added a commit
that referenced
this pull request
Sep 13, 2024
simonlechner
approved these changes
Sep 16, 2024
LuisPH3
approved these changes
Sep 16, 2024
facuMH
added a commit
that referenced
this pull request
Sep 16, 2024
facuMH
added a commit
that referenced
this pull request
Sep 16, 2024
* add gas selfdestruct test * remove selfdestruct gas functions. integrate them into operation func * improve constants comments and remove unused gas constants * make functions for self destruction costs and tests them * add test for all selfdestruct dynamic costs * changes requested in review. add and use getAccessCost from #730 * fix typo and rephrase revision check * fix comment phrasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the function
addressInAccessListand reworks its functionality intogetAccessCost. It also adds comprehensive documentation for the values used, and a test for the different cases.Note: static call prices after berlin should be 0, and warm cost should be applied in dynamic cost calcualtion (https://eips.ethereum.org/EIPS/eip-2929). This changes are also applied in this PR.