-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floria: Implement gas refunding #629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlechner
force-pushed
the
simon/floria-gas-refund
branch
3 times, most recently
from
July 29, 2024 12:56
7389f97
to
b80bf42
Compare
HerbertJordan
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should try to minimize test cases to make them more readable and verifiable.
simonlechner
force-pushed
the
simon/floria-gas-refund
branch
from
July 30, 2024 08:38
b80bf42
to
4fd4079
Compare
simonlechner
force-pushed
the
simon/floria-gas-refund
branch
from
July 30, 2024 13:13
4fd4079
to
0efa1dd
Compare
HerbertJordan
previously approved these changes
Jul 30, 2024
simonlechner
force-pushed
the
simon/floria-gas-refund
branch
2 times, most recently
from
July 31, 2024 06:22
3402d9c
to
58ac74b
Compare
HerbertJordan
previously approved these changes
Jul 31, 2024
simonlechner
force-pushed
the
simon/floria-gas-refund
branch
from
July 31, 2024 13:00
58ac74b
to
b47b003
Compare
HerbertJordan
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting the expectations using code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements gas refunding in Floria. Further, the gas integration tests are split into multiple functions and an end to end test for gas billing/handling using a mock interpreter is introduced.
Fixes #575 and #603.