Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floria: Implement gas refunding #629

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

simonlechner
Copy link
Contributor

@simonlechner simonlechner commented Jul 29, 2024

This PR implements gas refunding in Floria. Further, the gas integration tests are split into multiple functions and an end to end test for gas billing/handling using a mock interpreter is introduced.

Fixes #575 and #603.

@simonlechner simonlechner force-pushed the simon/floria-gas-refund branch 3 times, most recently from 7389f97 to b80bf42 Compare July 29, 2024 12:56
go/integration_test/processor/gas_billing_test.go Outdated Show resolved Hide resolved
go/integration_test/processor/gas_billing_test.go Outdated Show resolved Hide resolved
go/integration_test/processor/gas_billing_test.go Outdated Show resolved Hide resolved
go/integration_test/processor/processor_gas_test.go Outdated Show resolved Hide resolved
go/integration_test/processor/processor_gas_test.go Outdated Show resolved Hide resolved
go/integration_test/processor/processor_gas_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try to minimize test cases to make them more readable and verifiable.

HerbertJordan
HerbertJordan previously approved these changes Jul 30, 2024
go/processor/floria/processor_test.go Outdated Show resolved Hide resolved
HerbertJordan
HerbertJordan previously approved these changes Jul 31, 2024
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the expectations using code!

@simonlechner simonlechner merged commit 35121bf into main Aug 1, 2024
5 checks passed
@simonlechner simonlechner deleted the simon/floria-gas-refund branch October 29, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floria: Add gas refund after fail call
2 participants