Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancun RLP #81

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Cancun RLP #81

merged 2 commits into from
Jul 26, 2024

Conversation

cabrador
Copy link
Contributor

Description

This PR correctly implements addition of data added in Cancun fork into RLP package.
The RLPs need to be separate because the way Decode works is that it tries to decode RLP into structure, if it fails it tries another structure. As

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@cabrador cabrador requested a review from wsodsong July 25, 2024 12:13
wsodsong
wsodsong requested changes Jul 26, 2024
View reviewed changes
rlp/berlin.go Outdated Show resolved Hide resolved
rlp/berlin.go Outdated Show resolved Hide resolved
rlp/london.go Outdated Show resolved Hide resolved
@cabrador cabrador merged commit 97f4c87 into main Jul 26, 2024
1 check failed
@cabrador cabrador deleted the petr/cancun branch July 26, 2024 14:22
rpl-ffl pushed a commit that referenced this pull request Sep 25, 2024
@cabrador @rpl-ffl
Cancun RLP (#81)
a2ce52f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsodsong wsodsong wsodsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabrador @wsodsong