Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tests #80

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix incorrect tests #80

merged 1 commit into from
Jul 22, 2024

Conversation

cabrador
Copy link
Contributor

@cabrador cabrador commented Jul 19, 2024 •
edited
Loading

Description

This PR fix incorrect checks inside db tests and passes error type in UpdateDb.Get() using %w.

Type of change

  • Adds or updates testing

@cabrador cabrador requested a review from wsodsong July 19, 2024 12:31
@cabrador cabrador merged commit 54f019d into main Jul 22, 2024
1 check failed
@cabrador cabrador deleted the petr/fix-incorrectly-returned-errors branch July 22, 2024 13:34
rpl-ffl pushed a commit that referenced this pull request Sep 25, 2024
@cabrador @rpl-ffl
Fix incorrect checks in db tests; Return error using %w to pass error…
ce6b5bd 
… type. (#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsodsong wsodsong wsodsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabrador @wsodsong